Enhance boolean conversion logic for strings and numeric values#1776
Open
GFoniX wants to merge 1 commit intotypestack:developfrom
Open
Enhance boolean conversion logic for strings and numeric values#1776GFoniX wants to merge 1 commit intotypestack:developfrom
GFoniX wants to merge 1 commit intotypestack:developfrom
Conversation
Author
|
Hi @typestack, |
|
Very interesting, might be very useful 👍 |
Author
|
Is there something that can block my Pr ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update improves the boolean conversion logic when handling string values in the type mapping. The changes include:
This ensures more consistent and accurate conversions when dealing with strings that are either numeric or represent boolean values.
Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesFixes
fixes #676, fixes #626
This fix ensures that query parameters sent as strings, which are common in NestJS, are correctly converted to booleans when using class-transformer. It prevents incorrect boolean conversions that previously resulted in all such values being interpreted as true.
For exemple have '1', '0', 'true', 'false' result to having true.